From: Georges Basile Stavracas Neto Date: Mon, 1 Jun 2020 15:20:44 +0000 (-0300) Subject: workspacesView: Rename show to animateToOverview X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~320 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e7ec373aeebf46f6096f98b4a8ee1ae1e3454405;p=gnome-shell.git workspacesView: Rename show to animateToOverview WorkspacesDisplay is a ClutterActor subclass, and overriding the show and hide methods require chaining up, otherwise the actor isn't actually shown or hidden. To avoid clashing with the pre-existing show method, rename to animateToOverview. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295 --- diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js index 5c0dd9bb7..930e5b1e6 100644 --- a/js/ui/viewSelector.js +++ b/js/ui/viewSelector.js @@ -273,7 +273,7 @@ var ViewSelector = GObject.registerClass({ show() { this.reset(); - this._workspacesDisplay.show(this._showAppsButton.checked); + this._workspacesDisplay.animateToOverview(this._showAppsButton.checked); this._activePage = null; if (this._showAppsButton.checked) this._showPage(this._appsPage); diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js index 09155c5ae..b196427cc 100644 --- a/js/ui/workspacesView.js +++ b/js/ui/workspacesView.js @@ -608,7 +608,7 @@ class WorkspacesDisplay extends St.Widget { return this._getPrimaryView().navigate_focus(from, direction, false); } - show(fadeOnPrimary) { + animateToOverview(fadeOnPrimary) { this._updateWorkspacesViews(); for (let i = 0; i < this._workspacesViews.length; i++) { let animationType;